Repository navigation
docs correct the fromCode range description - #156
Closed
theluckystrike wants to merge 1 commit into
Closed
theluckystrike wants to merge 1 commit into
theluckystrike wants to merge 1 commit into
Conversation
Member
|
Hi! Gren code should not throw exceptions, so changing the docs is not a way to fix this issue. For backwards compatibility, we catch the exception and return the replacement character. We should also add a unit test to verify. |
Author
|
Thanks @robinheghan. I see this is fixed properly in 7be0d24 on release-7.5.0, with the try/catch returning Char.replacementChar and the docs kept as they were, so this docs change is no longer right. Closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
The fromCode doc comment said numbers outside the unicode range return the replacement character. The kernel uses String.fromCodePoint, which throws a RangeError for those inputs. This updates the doc comment and drops the now wrong example.